Skip to content

Fix serialization of priorParameters #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Oct 15, 2025
Merged

Fix serialization of priorParameters #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions petab/v2/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,8 +977,10 @@ def _serialize_prior_distribution(
return str(prior_distribution)

@field_serializer("prior_parameters")
def _serialize_prior_parameters(self, prior_parameters: list[str], _info):
return C.PARAMETER_SEPARATOR.join(prior_parameters)
def _serialize_prior_parameters(
self, prior_parameters: list[float], _info
) -> str:
return C.PARAMETER_SEPARATOR.join(map(str, prior_parameters))

@model_validator(mode="after")
def _validate(self) -> Self:
Expand Down
23 changes: 23 additions & 0 deletions tests/v2/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,29 @@ def test_parameter():
with pytest.raises(ValidationError, match="less than"):
Parameter(id="k1", lb=2, ub=1)

assert Parameter(
id="k1", estimate=True, lb=1, ub=2, prior_parameters=[1, 2]
).model_dump() == {
"id": "k1",
"lb": 1.0,
"ub": 2.0,
"nominal_value": None,
"estimate": "true",
"prior_distribution": "",
"prior_parameters": "1.0;2.0",
}
assert Parameter(
id="k1", estimate=False, nominal_value="8"
).model_dump() == {
"id": "k1",
"lb": None,
"ub": None,
"nominal_value": 8.0,
"estimate": "false",
"prior_distribution": "",
"prior_parameters": "",
}


def test_experiment():
Experiment(id="experiment1")
Expand Down