-
-
Notifications
You must be signed in to change notification settings - Fork 132
Add parameter for minimum consumption amounts #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 72.92% 73.19% +0.27%
==========================================
Files 21 21
Lines 5122 5137 +15
==========================================
+ Hits 3735 3760 +25
+ Misses 1387 1377 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
All tests, but one, pass locally: The failing test is |
|
@rickecon, despite the failing test, this PR is ready for your review. Perhaps you can try the failing test on your machine. I don't recall that failing before, but it's odd since nothing was changed related to the function tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
This PR adds a new parameter,
c_minthat represents the minimum consumption amounts for eachiconsumption good. This parameter was already outlined in the theory, but hadn't bee included in the model code.Resolves Issue #982.