Skip to content

Conversation

@jdebacker
Copy link
Member

This PR addresses Issues #144 and #143 by making ParamTools compatible with Marshmallow 4.0. The Marshmallow guide (which doesn't have a lot of detail) summarizing the changes.

@jdebacker
Copy link
Member Author

So far, this PR has:

  • Removed ordered objects (since they are now all ordered by default) (as done in PR Marshmallow 4 upgrades #145)
  • Set a context attribute in the BaseValidatorSchema, with the default being an empty dictionary

I'm currently stuck on how to create the fields attribute that is access, e.g., in the Parameters.specification method. Marshmallow had previously inferred fields, but now does not.

cc @hdoupe

@hdoupe hdoupe mentioned this pull request May 11, 2025
@hdoupe
Copy link
Collaborator

hdoupe commented May 11, 2025

@jdebacker , opened a pr on this branch with changes that should get this over the finish line if it looks good to you: jdebacker#1

we'll need to make sure to update this before releasing the new paramtools version with the marshmallow 4 changes:
https://github.com/conda-forge/paramtools-feedstock/blob/a33871dc3f5709822de2e99f76b4f4c1d2b0c1cb/recipe/meta.yaml#L23

@martinholmer
Copy link

Are the changes in this PR going to be the paramtools 0.20.0 version?
Or are there plans to bump the version number in a different pull request?

@jdebacker jdebacker marked this pull request as ready for review May 13, 2025 14:55
@jdebacker
Copy link
Member Author

@hdoupe Thanks for your finishing off this PR. I just bumped the version to 0.20.0 and I think this is ready to go.

Can you give the PR one final review (and merge if you think it's ready)?

Copy link
Collaborator

@hdoupe hdoupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jdebacker !

@jdebacker jdebacker merged commit 71be6a8 into PSLmodels:master May 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants