-
Notifications
You must be signed in to change notification settings - Fork 14
Marshmallow 4 upgrades #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So far, this PR has:
I'm currently stuck on how to create the cc @hdoupe |
|
@jdebacker , opened a pr on this branch with changes that should get this over the finish line if it looks good to you: jdebacker#1 we'll need to make sure to update this before releasing the new paramtools version with the marshmallow 4 changes: |
|
Are the changes in this PR going to be the paramtools 0.20.0 version? |
Add further updates for marshmallow 4
|
@hdoupe Thanks for your finishing off this PR. I just bumped the version to 0.20.0 and I think this is ready to go. Can you give the PR one final review (and merge if you think it's ready)? |
hdoupe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jdebacker !
This PR addresses Issues #144 and #143 by making ParamTools compatible with Marshmallow 4.0. The Marshmallow guide (which doesn't have a lot of detail) summarizing the changes.