Skip to content

Add attached patches to message view #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndersAstrand wants to merge 1 commit into from
Closed

Add attached patches to message view #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/assets/stylesheets/components/messages.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,18 +224,23 @@

.attachment-info {
display: flex;
gap: var(--spacing-3);
align-items: center;
font-size: var(--font-size-sm);
}

summary.attachment-info {
cursor: pointer;
display: list-item;
}

.filename {
font-weight: var(--font-weight-medium);
color: var(--color-text-primary);
}

.content-type {
color: var(--color-text-muted);
margin-left: var(--spacing-3);
}

.import-metadata {
Expand Down
17 changes: 13 additions & 4 deletions app/views/topics/_message.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,19 @@
.message-attachments
h4 Attachments:
- message.attachments.each do |attachment|
.attachment
.attachment-info
span.filename = attachment.file_name
span.content-type = attachment.content_type if attachment.content_type
- if attachment.patch?
details class="attachment"
Copy link
Collaborator

@dutow dutow Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these class="<x>" lines could all be like details.attachment

Copy link
Collaborator Author

@AndersAstrand AndersAstrand Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't used this template language before. Good to know! 🙂

summary class="attachment-info"
span.filename = attachment.file_name
span.content-type = attachment.content_type if attachment.content_type
pre class="attachment-content"
code class="language-diff"
= attachment.decoded_body
- else
.attachment
.attachment-info
span.filename = attachment.file_name
span.content-type = attachment.content_type if attachment.content_type

- if message.import_log.present?
.import-metadata
Expand Down