feat: add unified Logfire distributed tracing across FastAPI and Modal #56
+939
−810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds proper observability with trace context propagation so all spans from a single request appear together in Logfire, regardless of whether they run in FastAPI or Modal. Changes: - Add logfire to Modal base images and agent sandbox - Configure logfire with service names (policyengine-modal-uk/us, policyengine-agent) - Pass W3C traceparent from FastAPI to Modal spawn calls - Agent sandbox passes traceparent in HTTP requests back to API - Replace rich.console logging with logfire spans in all Modal functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper observability with trace context propagation so all spans from a single request appear together in Logfire, regardless of whether they run in FastAPI or Modal.
Changes:
Testing: Trigger a household calculation or agent question, then check Logfire for unified traces across policyengine-api, policyengine-modal-uk/us, and policyengine-agent services.