-
Notifications
You must be signed in to change notification settings - Fork 35
Fixed user profile page error #2598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
v-lerie
wants to merge
2
commits into
master
Choose a base branch
from
valerie/fix-profile-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| - bump: patch | ||
| changes: | ||
| added: | ||
| - Automatically create a user profile if none exists when fetching by auth0_id in the user-profile GET endpoint. | ||
| - Conditional logging setup in `gcp_logging.py` to use a local logger when `ENV=local`, disabling Google Cloud logging for local development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| from google.cloud.logging import Client | ||
| import os | ||
|
|
||
| logger = Client().logger("policyengine-api") | ||
| if os.getenv("ENV") == "local": | ||
| import logging | ||
|
|
||
| logger = logging.getLogger("local-logger") | ||
| logger.warning("Using local logger (GCP logging disabled)") | ||
| else: | ||
| from google.cloud.logging import Client | ||
|
|
||
| logger = Client().logger("policyengine-api") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| import json | ||
| from policyengine_api.services.user_service import UserService | ||
| from werkzeug.exceptions import BadRequest, NotFound | ||
| import time | ||
|
|
||
| user_profile_bp = Blueprint("user_profile", __name__) | ||
| user_service = UserService() | ||
|
|
@@ -64,7 +65,12 @@ def get_user_profile(country_id: str) -> Response: | |
| ) | ||
|
|
||
| if row is None: | ||
| raise NotFound("No such user") | ||
| _, row = user_service.create_profile( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue, blocking: I don't think this is the behavior we want here Ideally, we should raise a |
||
| primary_country=country_id, | ||
| auth0_id=auth0_id if auth0_id is not None else "", | ||
| username=None, | ||
| user_since=str(int(time.time())), | ||
| ) | ||
|
|
||
| readable_row = dict(row) | ||
| # Delete auth0_id value if querying from user_id, as that value | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue, blocking: I believe this code is bleed-over from another PR.
Please remove so that we can keep those changes isolated to their own PR.