-
Notifications
You must be signed in to change notification settings - Fork 3
Enable report sharing via URL #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
df837a0 to
6146c82
Compare
anth-volk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @SakshiKekre. This is in the right direction, but I don't see anywhere in this code that actually encodes the user-associated data, which was the original point of using the less ideal URL-based encoding instead of just passing the base report ID as part of the URL.
I'd recommend modifying this code such that, when a user clicks to share, the code takes the user-associated report and encodes all the user-associated records (but not the base ingredient records, since the user-associated records contain the base ingredient IDs)
Then, when a user accesses the shared link, the report page should fetch the entire user report, taking the encoded data to fill in user-associated records that don't exist in the database, then fetching the base ingredients out of the database.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3053901 to
ed89e62
Compare
This PR enables -
Changes