generated from mantinedev/vite-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Restructure codebase into separate website and calculator apps #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SakshiKekre
wants to merge
14
commits into
main
Choose a base branch
from
feat/app-split-restructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restructures the PolicyEngine app into a proper Turborepo monorepo with separate apps and shared packages.
New Structure
Key Changes
Apps separation:
apps/website/- Static website with NO Redux, NO React Query (lightweight)apps/calculator/- Interactive calculator with full Redux + React Query stackShared packages:
@policyengine/design-system- Design tokens, HomeHeader component, chart utilities@policyengine/shared- Country config,useCurrentCountryhook, geolocation routing, URL utilitiesCode consolidation:
New utilities:
replaceCountryInPath()- Clean URL manipulation for country switchingCOUNTRIES/WEBSITE_COUNTRIESarrays for dropdownscountryLabelsrecord for display namesTesting:
Before Merging
Rebase after PR feat: Allow multiple instances of the dev server to run simultaneously #540 - That PR adds dynamic port discovery which resolves the dev mode cross-app URL issue.
Vercel Dashboard - Configure Root Directory for each project:
policyengine-website→apps/websitepolicyengine-calculator→apps/calculatorDocumentation
See
repo-code-split-summary.mdfor detailed breakdown of all changes.Test Plan
npm run typecheckpassesnpm run packages:buildsucceedsnpm testin apps/website)