-
Notifications
You must be signed in to change notification settings - Fork 31
Fix fuel duty rates to use OBR November 2025 RPI forecasts #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MaxGhenis, I added a Python script to calculate and update the fuel rates. Changes
Usage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to provide a complete review - the diff content appears to be empty. The PR description mentions updates to fuel duty rates using OBR November 2025 RPI forecasts, which sounds like a reasonable parameter update, but I cannot verify the actual changes without seeing the diff.
From the file list, I can see:
- A changelog entry was added (good)
- Documentation files were modified (index.ipynb removed, index.md added)
- A new calculation script was added (
calculate_fuel_duty_rates.py) - The fuel duty parameter file was updated
- Test config was modified
Please share the actual diff content so I can review:
- Whether the new rate calculations are correct
- Whether the calculation script logic is sound
- What documentation changes were made
- Why the test config was modified
|
rereview pls? @PolicyEngine |
|
hey @PolicyEngine pls rereview now you have better code |
|
Thanks for the detailed work on this, @vahid-ahmadi! The approach of adding a calculation script that reads from A few observations:
For the reviewers: the key validation points would be:
@nikhilwoodruff - the PR looks ready for a detailed code review. Is there anything specific you'd like checked? |
|
@PolicyEngine give a full review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR correctly updates fuel duty rates to use OBR November 2025 RPI forecasts instead of outdated March 2025 forecasts. The changes are well-documented with a Python script that calculates the weighted annual averages, clear notes in the YAML file explaining the methodology, and proper references to OBR sources.
What's good:
- The calculation script (
calculate_fuel_duty_rates.py) is well-structured and provides reproducible calculations - The YAML file includes detailed notes showing how each annual average was computed
- References to OBR sources are properly included
- The changelog entry correctly describes this as a patch fix
- Converting the documentation from ipynb to markdown is a reasonable cleanup
Minor observations:
- The test expected values changed (
reforms_config.yaml) - presumably due to the updated fuel duty rates affecting the microsimulation outputs - The script adds a 2030 rate which wasn't mentioned in the PR description but is consistent with the methodology
- The calculation script is a helpful tool for future updates when new RPI forecasts become available
The approach is sound and the implementation looks correct.
policyengine_uk/parameters/gov/hmrc/fuel_duty/calculate_fuel_duty_rates.py
Show resolved
Hide resolved
|
@PolicyEngine can you resolve these thread please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR correctly updates fuel duty rates to use the November 2025 OBR RPI forecasts instead of the outdated March 2025 forecasts. The changes are well-documented with a helpful calculation script that makes future updates reproducible.
Key observations:
- The fuel duty rate updates are consistent with the stated methodology and the RPI values from
yoy_growth.yaml - The calculation script (
calculate_fuel_duty_rates.py) is a nice addition for maintainability - The test expected impacts have been updated appropriately
- The docs conversion from
.ipynbto.mdis a nice cleanup (unrelated to the main change but fine to include) - 2030 rate was added beyond what's in the PR description table, but this is consistent with the methodology
The previous review threads are documentation suggestions rather than blocking issues, so this is ready to merge.
policyengine_uk/parameters/gov/hmrc/fuel_duty/calculate_fuel_duty_rates.py
Show resolved
Hide resolved
|
(sorry @vahid-ahmadi ) @PolicyEngine rereview, resolve if you can |
|
@PolicyEngine rereview |
Summary
Changes
References