Fix invalid filing_status enum values in test files #6902
Merged
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the following invalid enum values that were silently converted to SINGLE (index 0) due to numpy.select's default behavior: - Utah: `single` (lowercase) → `SINGLE` - Missouri: `0` (numeric) → `SINGLE` - Colorado: `HEAD_OF_HOUSE_HOLD` (typo) → `HEAD_OF_HOUSEHOLD` - North Carolina: `WIDWO` (typo) → `SURVIVING_SPOUSE` These will cause test failures once policyengine-core#411 is merged, which adds validation to raise clear errors for invalid enum values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes invalid
filing_statusenum values in test files that were silently converted toSINGLE(index 0) due to a bug in policyengine-core (see #410).Changes
single(lowercase)SINGLE0(numeric)SINGLE0(numeric)SINGLEHEAD_OF_HOUSE_HOLD(typo)HEAD_OF_HOUSEHOLDWIDWO(typo)SURVIVING_SPOUSEContext
These invalid values didn't cause test failures because
numpy.select()inEnum.encode()returns 0 (the default) when no condition matches, silently converting invalid values to the first enum value.PolicyEngine/policyengine-core#411 adds validation to raise clear errors for invalid enum values. This PR should be merged first to prevent test failures when that fix is released.
Test Plan
filing_statusvalues in test files🤖 Generated with Claude Code