-
Notifications
You must be signed in to change notification settings - Fork 201
Add Oregon Medicaid for immigrants as separate program #6995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Oregon Medicaid for immigrants as separate program #6995
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6995 +/- ##
============================================
+ Coverage 76.92% 100.00% +23.07%
============================================
Files 1 7 +6
Lines 39 118 +79
Branches 4 0 -4
============================================
+ Hits 30 118 +88
+ Misses 8 0 -8
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR Review: Oregon Healthier Oregon Program🔴 Critical (Must Fix)
🟡 Should Address
🟢 Suggestions
Validation Summary
Verified Correct
Suggested Reference Updateschild_income_limit.yaml: reference:
- title: KFF - Oregon CHIP Income Eligibility at 305% FPL
href: https://www.kff.org/medicaid/state-indicator/medicaid-and-chip-income-eligibility-limits-for-children-as-a-percent-of-the-federal-poverty-level/child_max_age.yaml: reference:
- title: Oregon Health Authority - OHP Application (children ages 0-18)
href: https://www.oregon.gov/oha/hsd/ohp/pages/apply.aspxNext StepsTo auto-fix issues: Or address manually:
🤖 Generated with Claude Code |
- Update child_income_limit.yaml with KFF and healthinsurance.org refs that explicitly corroborate 305% FPL value - Update child_max_age.yaml with OHP Apply page ref (states ages 0-18) - Add healthinsurance.org ref to adult_income_limit.yaml - Replace hard-coded age < 19 with child_max_age parameter in cost file - Add comment explaining federal age 65 threshold - Add income boundary tests (139%, 305%, 306% FPL) - Add age cliff effect tests (18→19 transition) - Add DACA_TPS and ASYLEE immigration status tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes Applied🔴 Critical Issues Fixed
🟡 Should-Address Issues Fixed
Verification
Ready for re-review. 🤖 Generated with Claude Code |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate into one file per variable
policyengine_us/variables/gov/states/or/oha/healthier_oregon/or_healthier_oregon_cost.py
Outdated
Show resolved
Hide resolved
...tates/or/oha/healthier_oregon/eligibility/or_healthier_oregon_immigration_status_eligible.py
Show resolved
Hide resolved
...iables/gov/states/or/oha/healthier_oregon/eligibility/or_healthier_oregon_income_eligible.py
Outdated
Show resolved
Hide resolved
...yengine_us/parameters/gov/states/or/oha/healthier_oregon/eligibility/adult_income_limit.yaml
Outdated
Show resolved
Hide resolved
- Split or_healthier_oregon_cost.py into separate files (one per variable) - Create or_healthier_oregon_group variable for clarity in cost calculation - Convert immigration status eligibility to use list parameter with np.isin() - Simplify is_child assignment (remove intermediate variable) - Update parameter descriptions to use active voice 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes AppliedReview Comments Addressed
Verification
🤖 Generated with Claude Code |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
| metadata: | ||
| unit: /1 | ||
| period: year | ||
| label: OR Healthier Oregon adult income limit (% FPL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| label: OR Healthier Oregon adult income limit (% FPL) | |
| label: Oregon Healthier Oregon adult income limit (% FPL) |
And other label in parameter.
| @@ -0,0 +1,15 @@ | |||
| description: Oregon Healthier Oregon sets this income limit for adults as a percentage of FPL | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| description: Oregon Healthier Oregon sets this income limit for adults as a percentage of FPL | |
| description: Oregon limits gross income to this share of the federal poverty level for adults under the Healthier Oregon program. |
And other description in parameter.
Bring complete: country-models: parameter-architect agent to fix it.
|
|
||
| - name: Undocumented adult gets healthcare benefit value | ||
| period: 2024 | ||
| absolute_error_margin: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| absolute_error_margin: 1 | |
| absolute_error_margin: 0.1 |
The test should still pass
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class or_healthier_oregon_cost_if_enrolled(Variable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as DC's. Definitely worth it to break out the spending logic in medicaid_cost_if_enrolled to avoid duplicates.
Fixes #6366