Skip to content

Conversation

@DTrim99
Copy link
Collaborator

@DTrim99 DTrim99 commented Dec 29, 2025

Summary

Reverts the Virginia 2025 income tax update (commit 27d1932) that was merged without proper review.

The changes will be re-submitted in a new PR for proper review process.

Reverted Changes

  • 21 parameter files with 2025 Form 760 references
  • Rebate parameter updates for 2024 and 2025
  • 2025 tests added to existing test files

Next Steps

After this revert is merged, a new PR will be created with the same changes for proper review.

Copy link
Collaborator Author

@DTrim99 DTrim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

This PR reverts the Virginia 2025 income tax updates from commit 27d1932.

Changes Reviewed

Files Reverted (29 total):

  • 21 parameter files: Removing 2025 Form 760 references
  • Rebate parameter: Removing 2024 ($200/$400) and 2025 ($0) values
  • 8 test files: Removing 2025 test scenarios

CI Status

Failing:

  1. Check version - Missing changelog_entry.yaml. The "Build changelog" step is failing because no changelog entry was provided.
  2. Check uv.lock freshness - Lock file needs to be updated.

Pending:

  • Full test suites are still running

Passing:

  • Lint

Required Actions

  1. Add changelog_entry.yaml:
- bump: patch
  changes:
    changed:
      - Revert Virginia 2025 income tax parameter and test updates for re-review.
  1. Update uv.lock:
uv lock

Observations

  1. The revert scope appears correct - it's removing all 29 files that were modified in the original Virginia 2025 update.

  2. The PR description mentions that changes will be re-submitted in a new PR for proper review. Consider whether the original PR (#7057) could instead be updated to address any concerns, rather than reverting and resubmitting.

  3. Note that reverting re-introduces the typo "Appropirations" in refundable.yaml (the original PR fixed this to "Appropriations").

Summary

The revert changes look correct but the PR is missing a required changelog entry. Add the changelog_entry.yaml file and update uv.lock to fix CI failures.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (fd6b2c5) to head (d2b295d).
⚠️ Report is 74 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #7058       +/-   ##
============================================
- Coverage   100.00%   72.81%   -27.19%     
============================================
  Files           11     3550     +3539     
  Lines          146    51113    +50967     
  Branches         0      263      +263     
============================================
+ Hits           146    37219    +37073     
- Misses           0    13874    +13874     
- Partials         0       20       +20     
Flag Coverage Δ
unittests 72.81% <ø> (-27.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelMakarchuk PavelMakarchuk merged commit 7f0c553 into PolicyEngine:main Dec 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants