Skip to content

Conversation

@entantoencuanto
Copy link
Member

@entantoencuanto entantoencuanto commented Sep 10, 2021

✌️ What does this PR do?

Removes GobiertoDashboards and lets external gobierto engines to declare dynamically their own modules

This PR has some issues:

  • Some tests are failing because the GobiertoDashboards::Dashboard model is not available from main app
  • The fixtures on the gobierto-pro engine are not loaded in test enviroment, so the test introduced by it fail.

🔍 How should this be manually tested?

👀 Screenshots

Before this PR

After this PR

:shipit: Does this PR changes any configuration file?

  • new environment variable in .env.example?
  • new entry in config/application.yml?
  • new entry in config/secrets.yml?

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

  • new site configuration variable?
  • new site template?
  • new module/submodule settings?
  • significant changes in some feature?

@entantoencuanto entantoencuanto force-pushed the remove_gobierto_dashboards branch from f916dfc to 981e62a Compare November 16, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants