Skip to content

Conversation

@ascholerChemeketa
Copy link
Contributor

Goes with this PR on PreTeXt: PreTeXtBook/pretext#2178

@StevenClontz
Copy link
Member

Marking as a draft until accepted as part of core PreTeXt, but thanks for linking these up!

@StevenClontz StevenClontz marked this pull request as draft June 19, 2024 23:41
@StevenClontz
Copy link
Member

This is making me think that part of our test suite should be building the sample article; that way we don't need extra tests for odds and ends like this that have passed Rob's muster already.

@rbeezer
Copy link
Collaborator

rbeezer commented Jun 20, 2024

until accepted as part of core PreTeXt

Now part of PreTeXt.

@StevenClontz StevenClontz marked this pull request as ready for review June 20, 2024 21:51
@StevenClontz
Copy link
Member

Y'know @ascholerChemeketa if you're handling mermaid, and I'm working on pelican, who's got Sebastian and Flounder?

@StevenClontz
Copy link
Member

#758 includes a test of the sample article, so assuming there's Mermaid stuff there, let's get that merged to main first, then merge into here for a final integration test before merging.

@oscarlevin oscarlevin merged commit ab453cb into PreTeXtBook:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants