Skip to content

Conversation

@jdevalk
Copy link
Member

@jdevalk jdevalk commented Dec 16, 2025

So we're the top menu item.

@jdevalk jdevalk requested a review from aristath December 16, 2025 19:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Test on Playground
Test this pull request on the Playground
or download the zip

@jdevalk jdevalk requested a review from ilicfilip December 16, 2025 19:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

✅ Code Coverage Report

Metric Value
Total Coverage 31.51% 📉
Base Coverage 31.49%
Difference 📈 0.02%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

📊 File-level Coverage Changes (2 files)

📈 Coverage Improved

Class Before After Change
Progress_Planner\UI\Branding 33.33% 34.26% +0.93%
Progress_Planner\Admin\Page 31.29% 31.71% +0.42%
ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

Copy link
Collaborator

@ilicfilip ilicfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@jdevalk , what do you think about adding a filter for the position, so it can be used in pp-hosts plugin?

that way if we need to tweak something we can just release new pp-hosts version, instead of making a new PP release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants