Skip to content

Conversation

@Lapis-LJA
Copy link
Contributor

No description provided.

@Lapis-LJA Lapis-LJA changed the title 🐛 [Artifact 1260] 光球の杖が敵の足元に出うる問題を修正 🐛 [Artifact 1260] 光球の杖の光球が敵の足元に出うる問題を修正 Dec 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a positioning bug in artifact 1260 (Rod of Light Orb) where light orbs were spawning at enemy feet positions instead of at the raycast detection point. The fix also refactors the damage application logic in the explosion handler to use a tag-based target selection system.

  • Changed position restoration in recursive.mcfunction from at @e[...] to positioned ~0.5 ~0.5 ~0.5 to correctly compensate for the dx=0 detection offset
  • Refactored explosion damage logic to use a two-phase tag-and-damage approach for more precise targeting
  • Updated entity type selectors from #lib:living to #lib:living_without_player for consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Asset/data/asset/functions/object/1137.light_orb/tick/boom.mcfunction Refactors damage targeting to use tag-based selection with sphere and cube detection methods, updates entity type selectors
Asset/data/asset/functions/artifact/1260.rod_of_light_orb/trigger/recursive.mcfunction Fixes positioning bug by restoring coordinates after dx=0 entity detection instead of using at @e

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@haiiro2gou haiiro2gou merged commit 97ac6c7 into master Dec 25, 2025
2 checks passed
@haiiro2gou haiiro2gou deleted the fix/lapis_artifact1260 branch December 25, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants