Skip to content

Fix downsample = 0 handling. #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sozforex wants to merge 2 commits into
base: 3.0
Choose a base branch
from
+4 −4
Open

Fix downsample = 0 handling. #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5717b84
Fix downsample, credit to kywch
sozforex Dec 31, 2025
8f60bb3
fix downsample=0 handling in sweep
sozforex Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pufferlib/pufferl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,9 +802,9 @@ def stop(self):
self.stopped = True

def downsample(data_list, num_points):
if not data_list or num_points <= 0:
if not data_list or num_points < 0:
return []
if num_points == 1:
if num_points <= 1:
return [data_list[-1]]
if len(data_list) <= num_points:
return data_list
Expand Down
4 changes: 2 additions & 2 deletions pufferlib/sweep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,8 +559,8 @@ def __init__(self,
self.gp_max_obs = gp_max_obs # train time bumps after 800?
self.infer_batch_size = infer_batch_size

# Probably useful only when downsample=1 and each run is expensive.
self.use_success_prob = sweep_config['downsample'] == 1
# Probably useful only when downsample is 0 or 1 in a config and each run is expensive.
self.use_success_prob = sweep_config['downsample'] in (0, 1)
self.success_classifier = LogisticRegression(class_weight='balanced')

# This model is conservative. Aggressive early stopping interferes with and hampers GP model learning.
Expand Down
Loading