-
-
Notifications
You must be signed in to change notification settings - Fork 479
feat: add on_raw_member_update event #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3012/head:pr-3012
git checkout pr-3012This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3012/head |
385d39a to
e13a20a
Compare
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Soheab <33902984+Soheab@users.noreply.github.com>
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Signed-off-by: Soheab <33902984+Soheab@users.noreply.github.com>
…cord into feat/onrawmemberupdate
Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
NeloBlivion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, works fine with one adjustment required
idk if it's really an issue but for some reason my bot is firing user_update before raw_member_update, can anyone repro?
| """ | ||
|
|
||
| from typing import TypedDict | ||
| from typing import NotRequired, TypedDict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotRequired was only added in 3.11
| from typing import NotRequired, TypedDict | |
| from typing import TypedDict | |
| from typing_extensions import NotRequired |
| - Added `Attachment.read_chunked` and added optional `chunksize` argument to | ||
| `Attachment.save` for retrieving attachments in chunks. | ||
| ([#2956](https://github.com/Pycord-Development/pycord/pull/2956)) | ||
| - Added a new event called `on_raw_member_update` that is dispatched when a member is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to the new changelog section
Summary
This PR adds a new event called
on_raw_member_update. This event is dispatched regardless of whether the member is cached. Handy for bots with chunking disabled and other reasons.Fixes #3001
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.