fix: Fix bug that prevented the first block change event in a flyout from being dispatched #9539
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from being dispatched
BenHenning
reviewed
Dec 22, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
This seems like a very reasonable fix. Is it possible to add a test for this or is it too contrived?
Contributor
Author
|
Done! |
rachel-fenichel
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9486
Proposed Changes
This PR adds an
inhibitReflowWrapperinstance variable to the baseFlyoutclass and uses it to prevent the reflow wrapper from running in preference to unregistering and reregistering the reflow wrapper listener. The latter approach was mutating the listener array such that other listeners could be missed when dispatching events.