Skip to content

Conversation

@MichaelChirico
Copy link
Member

This avoids the way close() is done. We could also use local() but this code is already pretty nested, better to off-load to a helper IMO.

A broader question of whether we might just deprecate yaml=TRUE is left unaddressed, for now.

@MichaelChirico MichaelChirico added the code-quality Issues related to improving code quality/readability label Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (291a711) to head (811e4ff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7552   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          87       87           
  Lines       16733    16733           
=======================================
  Hits        16561    16561           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

No obvious timing issues in HEAD=yaml-header-helper
Comparison Plot

Generated via commit 811e4ff

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 0 seconds
Installing different package versions 22 seconds
Running and plotting the test cases 4 minutes and 6 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality Issues related to improving code quality/readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant