Skip to content

Fix fcoalesce handling of Date and IDate #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aksh08022006 wants to merge 2 commits into from
Closed

Fix fcoalesce handling of Date and IDate #7553

aksh08022006 wants to merge 2 commits into from

Conversation

@aksh08022006
Copy link

@aksh08022006 aksh08022006 commented Dec 30, 2025

Fixes an issue where fcoalesce() failed when mixing Date and IDate
inputs due to storage-mode mismatches.

Details

  • Normalizes Date / IDate inputs to Date with REAL storage before
    type/class checks
  • Ensures consistent Date output regardless of input order
  • Preserves existing behavior for non-date inputs

Tests

  • Added regression tests covering:
    • Date + IDate → Date
    • IDate NA fallback
    • Reversed input order (IDate + Date)

Fixes #7545

@aksh08022006 aksh08022006 deleted the fcoalesce-int-double branch December 30, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico Awaiting requested review from MichaelChirico MichaelChirico is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fcoalesce doesnt play nice w/ date and idate

1 participant

@aksh08022006