BugFix: NUMBER_BY_SYMBOL is a dict #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where NUMBER_BY_SYMBOL was incorrectly called as a function instead of being accessed as a dictionary. The change corrects the syntax from NUMBER_BY_SYMBOL(symbol) to NUMBER_BY_SYMBOL[symbol].
- Fixes incorrect function call syntax for dictionary access in the IRC trajectory animation function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kfir4444
reviewed
Sep 7, 2025
Collaborator
kfir4444
left a comment
kfir4444
left a comment
There was a problem hiding this comment.
lgtm. I wonder why this hasn't shown in tests... Could we check that?
kfir4444
reviewed
Dec 29, 2025
alongd
force-pushed
the
nbs
branch
3 times, most recently
from
04d2bda to
277433f
Compare
use `dict[key]`, not `dict(key)` in plotter
To avoid errors like: AssertionError: 160.00001525878906 != 160 within 5 places (1.52587890625e-05 difference)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
dict[key], notdict(key)in plotter