Ensure formatters only format, not modify results

[henriquemoody]

When I changed the library to not overwrite existing names 1, I wasn't happy with how FirstResultStringFormatter was changing the results, because the results should be completely ready by the time they arrive in the formatters.

This commit changes that behaviour, ensuring the results are complete with all necessary information by the time they reach the formatters.

Along with those changes, I refactored some stringifiers and simplified the InterpolationRenderer; we were not overwriting the "name" parameter anyway, as it was just an unnecessary overhead.

[Copilot]

Pull request overview

This PR introduces a new Subject class to encapsulate the relationship between Name, Path, and input values, consolidating data that was previously tracked separately in the Result class. This refactoring simplifies state management and provides a cleaner API for tracking validation subjects.

Key changes:

• Created new Subject class to hold input, path, name, and isNamePrin properties together
• Refactored Result class to use Subject instead of separate input, path, and name properties
• Updated all file references to access these properties through result->subject

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
library/Subject.php	New class that encapsulates input, path, name, and related state with immutable methods for creating modified copies
library/Result.php	Refactored to use Subject instead of individual properties; simplified methods like withPath, withName, and introduced withSubject
library/Name.php	Simplified by removing Path dependency and the withPath method; removed unused import
library/Rules/UndefOr.php	Updated to access input through result->subject->input
library/Rules/NullOr.php	Updated to access input through result->subject->input
library/ResultQuery.php	Updated to access name and path through result->subject
library/Message/Stringifier/NameStringifier.php	Refactored to work with Subject instead of Name for stringification
library/Message/InterpolationRenderer.php	Simplified parameter extraction using Subject; added Subject import
library/Message/Formatter/TemplateResolver.php	Updated to access path and name through result->subject
library/Message/Formatter/NestedListStringFormatter.php	Refactored to pass displayedName through method parameters and access name via result->subject->name
library/Message/Formatter/NestedArrayFormatter.php	Updated to access path through result->subject->path
library/Message/Formatter/FirstResultStringFormatter.php	Simplified by removing the parent name tracking logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (bf5f6c0) to head (9a30ce5).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1572      +/-   ##
============================================
- Coverage     97.54%   97.50%   -0.05%     
+ Complexity      999      995       -4     
============================================
  Files           211      213       +2     
  Lines          2280     2282       +2     
============================================
+ Hits           2224     2225       +1     
- Misses           56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.