Fix date overflow when parsing year-month format without day #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing date formats like "2026-02" that don't specify a day, DateTime::createFromFormat() was using the current day (29th) from the system date. This caused February 2026 to overflow to March 1st since February 2026 only has 28 days. Adding the '!' prefix resets all date components to Unix Epoch before parsing, ensuring the day defaults to 1 instead of using the current day.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
=========================================
Coverage 97.49% 97.49%
Complexity 986 986
=========================================
Files 205 205
Lines 2236 2236
=========================================
Hits 2180 2180
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you for the changes, @AmineMx! 🐼 Could you fix the broken check, and add some tests to cover your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing date formats like "2026-02" that don't specify a day, DateTime::createFromFormat() was using the current day (29th) from the system date. This caused February 2026 to overflow to March 1st since February 2026 only has 28 days.
Adding the '!' prefix resets all date components to Unix Epoch before parsing, ensuring the day defaults to 1 instead of using the current day.