-
Notifications
You must be signed in to change notification settings - Fork 775
Remove docheaders from all files #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I don't see much value on having those headers in the files, and I've seen that some packages (like Doctrine) are moving away from it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
=========================================
Coverage 97.54% 97.54%
Complexity 999 999
=========================================
Files 211 211
Lines 2280 2280
=========================================
Hits 2224 2224
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would like to keep them, and move to REUSE compliance. https://reuse.software/spec-3.3/ It's important for things like automated SBOM, especially now in the age of AI. The I can personally do that in a separate PR, as I am already used to the tool. |
|
The problem I see with having those copyrights is the same we have with the That means lots of files would have your name and mine, some just yours, some just mine, and some just the contributors names. The trouble I find is how much is enough to add someone's name there? I think it's an overhead, but I'd be happy if you want to take this on. |
|
The There is also Ideally, we should not require permission to add attribution to someone that commited in the past. For example, if we identify that some code came from some people X, we should be able to include that attribution. We would need to get explicit permission to remove attribution or simplify it. So, the sober position here would be to remove all of our (Alexandre's individual copyrights and Henrique's individual copyrights) and replace with "The Respect Project Team", but keep all other git commiters attributed more explicitly. For example, if Alan Turing contributed to a validator for Turing machines to our project, that validator would have a header like this: Doing that would be slightly harder than just use the We never provided guidelines for marking contributions, so we can't say "what is enough". In the lack of those guidelines, we should make a balanced effort to streamline what we can (our names -> "The Respect Project Team" to avoid verbosity) and keep other contributors intact. The guidelines for new contributions, IMHO, should be "if you changed a file, add SPDX-FileContributor if you want to". Anything other than that is kind of hard to do legally. For example, some projects require contributors to send an email donating the changes to the main team, in order to keep those headers and license info more simple. If we did that, we could replace all headers for a simple "The Respect Project Team" one that is REUSE compliant, but we can't do it for past contributions (unless we contact all the previous contributors individually, or re-implement what they did from scratch). The SPDX standard guarantees there is a consistency in how we annotate those contributions. If we change something, it's because REUSE made changes to the standard. In a sense, it prevents us from having to make hard decisions about this, instead delegating the responsibility of choosing the annotation format to a standards body. |
I don't see much value on having those headers in the files, and I've seen that some packages (like Doctrine) are moving away from it.