use open range for UnsetIterator #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes UnsetIterator consistent with all the other methods that take range arguments. Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
Member
|
That works. We could merge this. See if you prefer #499 |
Member
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes UnsetIterator consistent with all the other methods that take range arguments.
Type of Change
Changes Made
Change UnsetIterator take an open range [start, end) of uint64 to be consistent with other methods.
Breaking Changes
This an API-breaking change but the API is new so it's OK to do that.