Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rudrankriyam
Copy link
Contributor

@RocketChat/ios

  • Adding a new server follows the same steps as from the main authentication screen, with the option of sign up and login. It has been covered in the previous project.

  • Servers can be added and changed using the ServersListView.

  • However, instead of tapping the current server, double tapping on Messages opens and closes the ServersListView instead, which needs to be changed.

  • Adding a comma between the accessibility label of Rocket.Chat and serverURL sounds a bit better by creating pause in VoiceOver dictation.

  • Accessibility notifications for screen and layout changes

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #2750 into develop will decrease coverage by 1.56%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2750      +/-   ##
===========================================
- Coverage     46.1%   44.54%   -1.57%     
===========================================
  Files          626      626              
  Lines        28938    28943       +5     
===========================================
- Hits         13343    12892     -451     
- Misses       15595    16051     +456
Impacted Files Coverage Δ
...ket.Chat/Views/Subscriptions/ServersListView.swift 0% <0%> (ø) ⬆️
...t/Views/Subscriptions/SubscriptionsTitleView.swift 42.5% <0%> (-2.24%) ⬇️
...ubscriptionsList/SubscriptionsViewController.swift 1.4% <0%> (-0.02%) ⬇️
Rocket.Chat/Views/Base/BaseNavigationBar.swift 0% <0%> (-100%) ⬇️
Rocket.Chat/Views/Chat/ChatAnnouncementView.swift 0% <0%> (-83.34%) ⬇️
...ontrollers/Chat/MessagesViewControllerTyping.swift 0% <0%> (-77.78%) ⬇️
...ntrollers/Chat/MessagesViewControllerJoining.swift 0% <0%> (-71.74%) ⬇️
...Chat/Models/Mapping/LoginServiceModelMapping.swift 0% <0%> (-66.3%) ⬇️
...odel/AuthSettingsManagerPersistencyExtension.swift 0% <0%> (-62%) ⬇️
...trollers/Chat/MessagesViewControllerDrafting.swift 20% <0%> (-60%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5ad00...84be45e. Read the comment docs.

@rudrankriyam rudrankriyam changed the title [NEW] Project02 - Changing and adding servers [NEW] Project 02 - Changing and adding servers Aug 19, 2019
@rudrankriyam rudrankriyam changed the title [NEW] Project 02 - Changing and adding servers [NEW] Project 02 - Changing and adding servers VoiceOver accessible Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant