Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 21, 2025

Fixes issue where user messages disappear when typed during command execution.

Problem

When a command is running and the user types a message before clicking "Proceed While Running", the message was being lost. The frontend was only sending a terminal continue operation without including the user's typed text and images.

Solution

Modified the command_output case in handlePrimaryButtonClick to:

  • Send the user's message as a messageResponse when text/images are present
  • Clear the input state after sending (consistent with other cases)
  • Fall back to the existing terminal continue operation when no message is typed

The backend in ExecuteCommandTool.ts already properly handles the messageResponse case, so no backend changes were needed.

Changes

  • webview-ui/src/components/chat/ChatView.tsx: Updated command_output handling in handlePrimaryButtonClick

View task on Roo Code Cloud

When a command is running and user types a message before clicking
"Proceed While Running", the message was being lost. The frontend
was only sending a terminal continue operation without including
the user's typed text and images.

Fixed by sending the message as a messageResponse (similar to other
tool cases) when text/images are present, which the backend already
properly handles in ExecuteCommandTool.ts.

Fixes issue where messages disappear during command execution.
@roomote
Copy link
Contributor Author

roomote bot commented Dec 21, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The fix correctly addresses the message loss problem during command execution by sending the user's typed message as an askResponse with messageResponse type when there is input, while falling back to the original terminalOperation: continue behavior when no message is typed. The backend already properly handles this case, so no backend changes were needed.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants