-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: Add evally test runner and implementation for vscode-evals #10330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All issues from previous reviews have been addressed. No new issues found in the latest commit.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| await resetTestFile(file) | ||
| } | ||
| } | ||
| const waitFor = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The waitFor and sleep utility functions are defined here and also re‐implemented in other files (e.g. in src/suite/index.ts). Consider extracting these functions into a shared utility module to avoid code duplication.
This comment was generated because it violated a code review rule: irule_tTqpIuNs8DV0QFGj.
23f66c3 to
4f8ad4c
Compare
4f8ad4c to
c3ad4d3
Compare
Description
Adds a new test runner designed to evaluated tests over multiple configurable runs. This method allows the tests to be evaluated based on non-deterministic output of the test results. The Testing matrix can also be configured with different suite specific variables and will run the suite with multiple sets of variables to "evaluate" performance based on different inputs.
Adds a new test suite that utilizes the new test runner for apply-diff tests.
Test Procedure
Pre-Submission Checklist
Important
Introduces
evallytest runner for non-deterministic outputs and matrix configurations, addingapply-difftest suite and supporting configurations invscode-evals.evallytest runner for non-deterministic test outputs and configurable test matrices.apply-difftest suite usingevallyinapplyDiff.matrix.test.ts..env.local.sample,.vscode-test.mjs,eslint.config.mjs, andtsconfig.esm.jsonforvscode-evals.package.jsonscripts for testing and building invscode-evals.knip.jsonto ignorevscode-evals.runTest.tsto execute tests using@vscode/test-electron.applyDiff.matrix.test.tsandsampleMatrix.test.ts.standaloneRunner.tsfor running matrix tests from CLI.utils.tsfor test execution.@roo-code/evallypackage withTestMatrixRunnerandtypesfor matrix testing.evallypackage with build and test scripts inpackage.json.This description was created by
for 032d4a5. You can customize this summary. It will automatically update as commits are pushed.