fix(gemini): upgrade @google/genai to support thinkingLevel for Gemini 3 models #10332
+46
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i 3 models The previous SDK version (1.29.1) did not include the `thinkingLevel` property in `ThinkingConfig`, causing INVALID_ARGUMENT errors when using Gemini 3 Pro and Flash models which require effort-based reasoning configuration via `thinkingLevel`. Changes: - Update @google/genai from ^1.29.1 to ^1.30.0 (adds thinkingLevel support) - Import ThinkingLevel enum and map lowercase effort values to SDK enum values - Update GeminiReasoningParams type to use SDK's ThinkingConfig directly - Update tests to expect uppercase ThinkingLevel enum values
dosubot
bot
added
size:M
Contributor
Review completed. One issue flagged for follow-up.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| '@google/genai': | ||
| specifier: ^1.29.1 | ||
| version: 1.29.1(@modelcontextprotocol/sdk@1.12.0) | ||
| specifier: ^1.30.0 |
Contributor
There was a problem hiding this comment.
The lockfile resolves @google/genai to 1.34.0 (because src/package.json uses ^1.30.0). If the intent is to only take the minimal bump described in the PR/changeset (1.30.x), consider pinning (for example ~1.30.0) or updating the PR/changeset text to match that we are taking latest 1.x. Note 1.34.0 also declares a peer dependency on @modelcontextprotocol/sdk ^1.24.0 (optional), while this repo pins 1.12.0.
Fix it with Roo Code or mention @roomote and request a fix.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous SDK version (1.29.1) did not include the
thinkingLevelpropertyin
ThinkingConfig, causing INVALID_ARGUMENT errors when using Gemini 3 Proand Flash models which require effort-based reasoning configuration via
thinkingLevel.Changes:
Important
Upgrade
@google/genaito 1.30.0 to supportthinkingLevelfor Gemini 3 models, updating logic and tests accordingly.@google/genaifrom^1.29.1to^1.30.0inpackage.jsonto supportthinkingLevel.ThinkingLevelenum and map lowercase effort values to SDK enum values inreasoning.ts.GeminiReasoningParamstype to use SDK'sThinkingConfigdirectly inreasoning.ts.reasoning.spec.tsto expect uppercaseThinkingLevelenum values.This description was created by
for 41c99fa. You can customize this summary. It will automatically update as commits are pushed.