Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jan 8, 2026

Summary

When the backend provider (Roo Code Cloud) terminates a stream prematurely, users previously saw raw error messages like "terminated" without context. This made it unclear that the error came from the provider, not the extension itself.

Changes

  • Added i18n translation key streamTerminatedByProvider in src/i18n/locales/en/common.json
  • Updated error handling in src/core/task/Task.ts to use the new i18n key when formatting stream termination errors
  • Added translations for all 17 supported languages

Message Translations

Language Translation
English Provider ended the request
Catalan El proveïdor ha finalitzat la sol·licitud
German Der Anbieter hat die Anfrage beendet
Spanish El proveedor finalizó la solicitud
French Le fournisseur a terminé la demande
Hindi प्रदाता ने अनुरोध समाप्त किया
Indonesian Penyedia mengakhiri permintaan
Italian Il provider ha terminato la richiesta
Japanese プロバイダーがリクエストを終了しました
Korean 제공자가 요청을 종료함
Dutch Provider heeft het verzoek beëindigd
Polish Dostawca zakończył żądanie
Portuguese (BR) Provedor encerrou a solicitação
Russian Провайдер завершил запрос
Turkish Sağlayıcı isteği sonlandırdı
Vietnamese Nhà cung cấp đã kết thúc yêu cầu
Chinese (Simplified) 提供方终止了请求
Chinese (Traditional) 提供方終止了請求

Before

Users saw raw error like: terminated

After

Users see: Provider ended the request: terminated

Impact

Users will now understand when errors are caused by the backend provider (timeouts, rate limits, backend issues) rather than the extension itself.

Closes ROO-415

…ider

When the backend provider terminates a stream prematurely, users now see
'Stream terminated by provider: <error>' instead of just the raw error.
This makes it clear the error came from the provider, not the extension.

- Added i18n translation key 'streamTerminatedByProvider'
- Updated Task.ts to wrap provider errors with contextual prefix

Closes ROO-415
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners January 8, 2026 16:09
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Jan 8, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 8, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The new commit updates the streamTerminatedByProvider i18n key with a clearer message ("Provider ended the request") and adds translations to all 18 supported locales. The changes are consistent and well-implemented.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

…yProvider

- Changed English text from 'Stream terminated by provider' to 'Provider ended the request' (more concise and user-friendly)
- Added translations for all 17 supported languages: ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW
- All translations validated with find-missing-translations script
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jan 8, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2026
@mrubens mrubens merged commit b7bd859 into main Jan 9, 2026
10 checks passed
@mrubens mrubens deleted the feature/roo-415-improve-error-messaging-for-stream-termination-errors-from branch January 9, 2026 15:03
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 9, 2026
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants