Improve handling multiple delimiters in input #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
approved these changes
Jun 26, 2025
Member
|
Can you add an entry to the changelog? 🙏🏻 |
Contributor
Author
|
Thanks, updated! |
Merged
sunny
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent update,
bigdecimalnow parses1.inputs as1, instead of throwing an exception (ruby/bigdecimal#302). With the change, monetize parses inputs like2..30as2now, but previously it would throw an exception, passed down from BigDecimal.The spec is already in place:
spec/monetize_spec.rb:406, but it won't fail until Ruby 3.4.0This PR updates the code to preserve the behavior with the newest version of BigDecimal.
Additionally, from Ruby 3.4, BigDecimal is no longer part of the standard library, so this PR updates the Gemfile accordingly.