Skip to content

BREAKING CHANGE: Set default port to 8883 for mqtt TLS connections #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bj00rn wants to merge 1 commit into from
Closed

BREAKING CHANGE: Set default port to 8883 for mqtt TLS connections #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/configuration/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ def __parse_mqtt_transport(args: Namespace, config: Configuration) -> None:

if parse_result.port:
config.mqtt_port = parse_result.port
elif config.mqtt_transport_protocol == TransportProtocol.TCP:
config.mqtt_port = 1883
elif config.mqtt_transport_protocol == TransportProtocol.TLS:
config.mqtt_port = 8883
else:
config.mqtt_port = 9001
config.mqtt_port = 1883
config.mqtt_host = str(parse_result.hostname)


Expand Down Expand Up @@ -183,8 +183,8 @@ def __add_mqtt_argument_group(
"--mqtt-uri",
help="""The URI to the MQTT Server.
TCP: tcp://mqtt.eclipseprojects.io:1883
WebSocket: ws://mqtt.eclipseprojects.io:9001
TLS: tls://mqtt.eclipseprojects.io:8883""",
TLS: tls://mqtt.eclipseprojects.io:8883
Leave empty to disable MQTT.""",
dest="mqtt_uri",
required=False,
action=EnvDefault,
Expand Down