-
Notifications
You must be signed in to change notification settings - Fork 31
Migrate to aiomqtt #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Migrate to aiomqtt #371
Conversation
8fd4c71 to
abd57b3
Compare
|
@bj00rn I'm just back from vacation. I'll postpone this for the next release |
|
@nanomad had a look yet? I just did a rebase to fix lock file |
99504a8 to
42e2f1e
Compare
42e2f1e to
63cc251
Compare
3fd6c08 to
c7f515b
Compare
|
@nanomad Feeling quite confident that this is ready for merge if you are interested. I've been running this locally for a while now. Had some issues with the Birth/keepalive and LWT. The client now sends birth message with If this PR is accepted i could rework the subscription logic as subscription, no need to resubscribe on reconnect since |
Replace gmqtt with aiomqtt (async wrapper around paho-mqtt). I have major issues with getting TLS working when running broker behind reverse proxy. I've scoured the Issues section at gmqtt and TLS support seems patchy.
Sorry for spamming PRs 🤓
Rationale
Might seem a bit backward since the resent migration from paho-mqtt but aiomqtt is a wrapper around paho with async support.
gmqtt
seems to have patchy TLS support
not well maintained
aiomqtt (aka mqtt-asyncio)
well maintained 3+ releases 2025
good community support since uses underlying paho-mqtt
Working TLS
supports websockets and unix file connections
Changes in this PR
aiomqttretain=True,qos=1for birth message.qos=1for LWT