-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Rb fix steep issues #16752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Rb fix steep issues #16752
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
🔗 Related Issues
This continues the work started here: #10943
💥 What does this PR do?
This PR fixes all Steep by updating RBS signature files
Key changes:
🔧 Implementation Notes
All fixes were made at the RBS level without modifying any Ruby source code.
💡 Additional Considerations
severity_level: errorto only fail on errors, not warningsFuture work could include:
🔄 Types of changes
PR Type
Bug fix, Enhancement
Description
Updated Steep type checker to v1.10.0 and fixed RBS signature files
Reduced type checking errors from 66 to 64 by improving type annotations
Added missing RBS signatures for BiDi, DevTools, and other modules
Configured Steep Rake task to report only errors, suppressing warnings
Updated Ruby version to 3.2.8 and refreshed gem dependencies
Diagram Walkthrough
File Walkthrough
2 files
Update Ruby version to 3.2.8Add Steep configuration template file3 files
Update gem checksums for dependenciesUpgrade Steep from 1.5.0 to 1.10.0Update RBS collection with new gem signatures9 files
Add Steep Rake task with error-level severityAdd RBS signatures for rubyzip gemDefine Window class with proper attributesAdd new FedCM dialog driver extension signaturesAdd NoSuchTargetError exception classAdd new PrintOptions class RBS signaturesAdd RUBYZIP_V3 constant definitionAdd initialize method signature for Firefox ServiceAdd BINARY_ENCODINGS constant and encoding methods20 files
Reorganize ignored files and reduce error countFix method signatures with keyword argumentsAdd pattern_type parameter and fix return typeUse union types for nullable attributesUse union types for nullable reason attributeSpecify concrete types for instance variablesImprove type specificity for prefs methodsAdd target_type parameter and specify return typeAdd missing _Driver include for moduleAdd missing _Driver include for moduleImprove type annotations for class variablesFix initialize_local_driver signature with blockImprove type signatures for private methodsAdd delegated methods and fix callback typesFix initialize signature and add_callback return typeAdd target_type parameter to initializationSpecify concrete type for EXTENSIONS constantAdd Bridge parent class inheritanceFix bidi method return type to BiDi classSpecify concrete types for timeouts methods1 files