Move test files so that file structure matches constant nesting structure #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Follow-up to #276 (comment)
In this PR, we're moving test files into folder structures that matches their naming convention. Although we are not using
zeitwerkto load test files, we thought this is a best practice that improves navigatability of the codebase.What approach did you choose and why?
I chose
test/*as a sort of "autoload" path in zeitwerk parlance, with anything that follows that to constitute a portion of the constant namespacing.That is,
test/supportandtest/integrationare organizational units to organize test files into general buckets. Everything that follows represents a portion of the namespace.What should reviewers focus on?
Does the nesting make sense?
Should we enforce this by actually loading test constants with zeitwerk?
Type of Change
Checklist