Add installation and packaging targets #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uekerman
reviewed
Jan 4, 2026
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Slight problems, otherwise good.
Comment on lines
+6
to
+9
| set(CPACK_PACKAGE_VERSION_MAJOR "0") | ||
| set(CPACK_PACKAGE_VERSION_MINOR "1") | ||
| set(CPACK_PACKAGE_VERSION_PATCH "0") | ||
| set(CPACK_PACKAGE_VERSION "0.1.0") |
Member
There was a problem hiding this comment.
No need to specify both, and better use those from the project description.
|
|
||
| set(CPACK_GENERATOR "TGZ;DEB") | ||
|
|
||
| set(CPACK_PACKAGING_INSTALL_PREFIX "${CMAKE_INSTALL_PREFIX}") |
Member
There was a problem hiding this comment.
Let CPack handle this, don't specify manually. You don't want to install in usr/local.
Comment on lines
+6
to
+11
| E: cpackexample: file-in-usr-local [usr/local/bin/cpackexample] | ||
| E: cpackexample: file-in-usr-local [usr/local/include/cpackexamplelib/fem.hpp] | ||
| E: cpackexample: file-in-usr-local [usr/local/include/cpackexamplelib/filesystem.hpp] | ||
| E: cpackexample: file-in-usr-local [usr/local/include/cpackexamplelib/flatset.hpp] | ||
| E: cpackexample: file-in-usr-local [usr/local/include/cpackexamplelib/yamlParser.hpp] | ||
| E: cpackexample: file-in-usr-local [usr/local/lib/libcpackexamplelib.a] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add installation and packaging targets
This PR adds CMake install rules and CPack configuration to generate
.tar.gzand
.debpackages for thecpackexampleproject.Build & Package
Inside the Docker container:
This produces:
cpackexample-0.1.0-Linux.tar.gzcpackexample_0.1.0_amd64.debBoth archives contain the installed executable, library, and header files.
Debian Package Test
The installed executable runs correctly.
Lintian
lintianwas executed as required:lintian ./cpackexample_0.1.0_amd64.deb > lintian_output.txtThe report is included in the repository.