fix: don't only rely on apt if on Linux #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syozik
reviewed
Nov 17, 2025
This was referenced Nov 17, 2025
jfuginay
added a commit
to jfuginay/omni-BASE
that referenced
this pull request
Dec 31, 2025
Fix IP address fields showing commas instead of periods in German and other locales. Changed keyboard type from .decimalPad to .URL to ensure periods are always available regardless of device language. Fixes Snapchat#35 Changes: - MeshtasticTCPConnectionView: Update keyboard type for IP input - MeshtasticDevicePickerView: Update keyboard type for IP input - Bump version to 2.7.1 (build 6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, valdi's setup commands assume all Linux setups have
apt/apt-get. While this isn't a complete implementation for every distro, this should solve the problem of trying to install all dependencies withapteven if it's not present on the system.