updated the rdflib for ESM builds #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the ESM builds by correctly configuring webpack externals for the rdflib dependency. The ESM bundles were failing because they incorrectly referenced rdflib as the UMD global $rdf instead of as an ES module import named rdflib.
Key changes:
- Created a new
externalsESMconfiguration object that maps rdflib to'rdflib'for ES module imports - Updated both ESM build configurations (minified and unminified) to use the new externals configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import path from 'path' | ||
| import TerserPlugin from 'terser-webpack-plugin' | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Unnecessary blank line added. Consider removing this extra whitespace for cleaner formatting.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESM version was not working. Webpack needed to be improved.