Skip to content

Conversation

@timea-solid
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 6, 2025 13:39
@timea-solid timea-solid merged commit b3036f2 into main Dec 6, 2025
9 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the package version from 4.0.0 to 4.0.1, indicating a patch release. Additionally, it converts the UMD bundle test file to use ES modules with import maps, changing from testing locally-built UMD bundles to testing the published ESM package via the esm.sh CDN.

  • Version bumped from 4.0.0 to 4.0.1 (patch release)
  • Test file converted from UMD bundle testing to ESM module testing
  • Test now uses esm.sh CDN to load published packages instead of local builds

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Version incremented to 4.0.1 for patch release
test/testBundles/test-umd.html Converted from UMD bundle test to ESM module test using import maps and esm.sh CDN; however, the filename and heading still reference "UMD" which is inconsistent with the new implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<title>Solid Logic UMD Bundle Test</title>
</head>
<body>
<h1>Solid Logic UMD Bundle Browser Test</h1>
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading still says "Solid Logic UMD Bundle Browser Test", but the test has been converted to use ES modules (ESM) with import maps instead of a UMD bundle. The heading should be updated to "Solid Logic ESM Module Browser Test" or similar to accurately reflect what is being tested.

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +14
"rdflib": "https://esm.sh/rdflib",
"solid-logic": "https://esm.sh/solid-logic"
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import map points to https://esm.sh/solid-logic which will load the published version from npm. This means the test won't be testing the local development version of the code. If the intent is to test local changes before publishing, consider either: 1) pointing to a local build, 2) creating a separate test file for CDN validation, or 3) adding a comment explaining this tests the published version.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants