Implement the by_side grouping with probes #4272
Merged
+84
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add "auto" mode
for more information, see https://pre-commit.ci
…ikeinterface into two_side_probes_grouping
alejoe91
reviewed
Dec 23, 2025
alejoe91
reviewed
Dec 23, 2025
alejoe91
reviewed
Dec 23, 2025
alejoe91
requested changes
Dec 23, 2025
Member
alejoe91
left a comment
alejoe91
left a comment
There was a problem hiding this comment.
I would be less strict in the by_shank and by_side modes
alejoe91
reviewed
Dec 23, 2025
alejoe91
reviewed
Dec 23, 2025
for more information, see https://pre-commit.ci
…ikeinterface into two_side_probes_grouping
alejoe91
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be merged first:
SpikeInterface/probeinterface#382
SpikeInterface/probeinterface#391
set_probe() has now "auto" "by_probe" "by_shank" "by_side"
The default is auto