Skip to content

Conversation

@LeCarbonator
Copy link
Contributor

@LeCarbonator LeCarbonator commented Nov 20, 2025

🎯 Changes

The PR addresses two memory leaks related to the EventClient:

  • Unsubscribe from event listeners on cleanup
  • Fix queuedEvents from piling up FormApi references

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: 01f1ce3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@tanstack/form-core Patch
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch
@tanstack/solid-form-devtools Patch
@tanstack/react-form-nextjs Patch
@tanstack/react-form-remix Patch
@tanstack/react-form-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2025

View your CI Pipeline Execution ↗ for commit 01f1ce3

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 48s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-18 09:52:47 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1866

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1866

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1866

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1866

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1866

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1866

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1866

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1866

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1866

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1866

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1866

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1866

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1866

commit: 01f1ce3

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.41%. Comparing base (6892ed0) to head (01f1ce3).
⚠️ Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/FormApi.ts 25.00% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   90.35%   89.41%   -0.94%     
==========================================
  Files          38       48      +10     
  Lines        1752     1937     +185     
  Branches      444      483      +39     
==========================================
+ Hits         1583     1732     +149     
- Misses        149      184      +35     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeCarbonator
Copy link
Contributor Author

Related PR: TanStack/devtools#272

@martinliptak
Copy link

Also experiencing this, I made the forms client only to temporarily mitigate the issue.

@LeCarbonator LeCarbonator merged commit 36fa503 into main Dec 18, 2025
6 of 7 checks passed
@LeCarbonator LeCarbonator deleted the fix-memory-leak branch December 18, 2025 09:59
@github-actions github-actions bot mentioned this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants