-
-
Notifications
You must be signed in to change notification settings - Fork 566
fix(form-core): Fix memory leaks from EventClient #1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 01f1ce3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 01f1ce3
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
- Coverage 90.35% 89.41% -0.94%
==========================================
Files 38 48 +10
Lines 1752 1937 +185
Branches 444 483 +39
==========================================
+ Hits 1583 1732 +149
- Misses 149 184 +35
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Related PR: TanStack/devtools#272 |
|
Also experiencing this, I made the forms client only to temporarily mitigate the issue. |
🎯 Changes
The PR addresses two memory leaks related to the EventClient:
queuedEventsfrom piling upFormApireferences🚀 Release Impact