perf: assorted improvements to help JVM to inline methods

[triceo]

These changes are focused mostly on splitting large methods into smaller ones, as the JVM identified them as both hot and too big to inline.

This brings a minor statistically significant performance improvement in select use cases.

[Copilot]

Pull request overview

This PR implements various performance optimizations across the codebase through code refactoring and modernization. The changes focus on improving code maintainability while potentially enhancing runtime performance.

• Refactored complex methods into smaller, more focused helper methods for better readability and potential inlining optimizations
• Modernized code style with var keyword usage and switch expressions
• Optimized queue processing by using poll() instead of iteration followed by clear()

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
ConsecutiveSetTree.java	Extracted the monolithic add method into focused helper methods (addItemToBag, addExistingItem, addSubsequentItem, addFirstItem, addSequence) for better code organization and readability
CartesianProductMoveSelector.java	Modernized code with var declarations, extracted findStartingIndex and buildMove helper methods, and replaced if-else chains with switch expressions for cleaner code
StaticPropagationQueue.java	Optimized queue processing by replacing for-each iteration + clear with while + poll pattern, and parameterized shared logic with Consumer for code reuse
AbstractGroupNode.java	Extracted updateGroup method and simplified conditional logic with early returns to improve code clarity

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The parameter name newNextSequence in the two-parameter addSequence method is misleading. At line 166, this method is called with prevBag as the argument, but it's named newNextSequence in the parameter list at line 233. This suggests the parameter should be named something like previousSequence or adjacentSequence to accurately reflect what it represents, improving code clarity and reducing potential confusion.

Suggested change

	SequenceImpl<Value_, Point_, Difference_> newNextSequence) {
	var newBag = new SequenceImpl<>(this, addingItem);
	startItemToSequence.put(addingItem, newBag);
	startItemToPreviousBreak.put(addingItem, new BreakImpl<>(newBag, newNextSequence));
	SequenceImpl<Value_, Point_, Difference_> adjacentSequence) {
	var newBag = new SequenceImpl<>(this, addingItem);
	startItemToSequence.put(addingItem, newBag);
	startItemToPreviousBreak.put(addingItem, new BreakImpl<>(newBag, adjacentSequence));

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud