chore: remove PlanningClone-related interfaces #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the PlanningCloneable and PlanningImmutable interfaces and their associated test implementations, which are remnants from old Python work that are no longer needed.
- Deletes the PlanningCloneable and PlanningImmutable interface definitions
- Removes all test domain classes that implemented PlanningCloneable
- Removes cloning logic that handled PlanningCloneable instances, simplifying the code to use direct constructor calls
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| PlanningCloneableSolution.java | Deleted test solution class that implemented PlanningCloneable |
| PlanningCloneableMap.java | Deleted test map wrapper that implemented PlanningCloneable |
| PlanningCloneableList.java | Deleted test list wrapper that implemented PlanningCloneable |
| PlanningCloneableEntity.java | Deleted test entity that implemented PlanningCloneable |
| AbstractSolutionClonerTest.java | Removed test case and imports for PlanningCloneable functionality |
| GizmoSolutionClonerImplementor.java | Removed PlanningCloneable handling logic, simplified to direct constructor calls |
| GizmoCloningUtils.java | Removed PlanningCloneable import and related check |
| FieldAccessingSolutionCloner.java | Removed PlanningCloneable handling from clone construction methods |
| DeepCloningUtils.java | Removed PlanningImmutable/PlanningCloneable conflict validation |
| PlanningImmutable.java | Deleted interface definition |
| PlanningCloneable.java | Deleted interface definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
These are remnants of the old Python work which are no longer necessary.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Christopher-Chianelli
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are remnants of the old Python work which are no longer necessary.