Refactor shipping_rate calculation upon selecting different rates #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The easypost_shipments were being created again upon retrieving shipping_rates. Hence modified estimator to check if an EasyPost shipment has already been created for the shipment. If it exists, it fetches the stored shipping rates instead of creating a new EasyPost shipment. Upon updating default shipping rate, all the other shipping rates of a shipment were being discarded. The change ensure that the newly selected shipping rate is set while also keeping the rest. Once the shipping rate is updated, the cost of shipment needs to be updated. Thereby reloading shipment to reflect any updates to the selected shipping rate also ensuring that the shipment cost is recalculated based on the latest selected shipping rate.
JustShah
force-pushed
the
fix-buying-easypost-shipping-rate
branch
from
2330db4 to
41f5bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.