Skip to content

Conversation

@sindharta
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the _NORMALMAP shader keyword from Unity Toon Shader files, simplifying the shader code by eliminating conditional compilation paths related to normal mapping. The changes also remove version-specific compatibility checks for older Unity versions.

Key Changes:

  • Removed _NORMALMAP shader feature declarations from shader templates and generated shaders
  • Simplified HLSL code by removing _NORMALMAP conditional blocks and related vertex light handling
  • Cleaned up version-specific compatibility code (VERSION_LOWER checks)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
UniversalToonBodyShadingGradeMap.hlsl Removed _NORMALMAP conditional block and version checks, simplified input data initialization
UniversalToonBodyDoubleShadeWithFeather.hlsl Removed _NORMALMAP conditional block and version checks, simplified input data initialization
UnityToonTessellation.shadertemplate Removed _NORMALMAP shader feature declaration
UnityToon.shadertemplate Removed _NORMALMAP shader feature declaration
UnityToonTessellation.shader Removed _NORMALMAP shader feature and updated auto-generation timestamp
UnityToon.shader Removed _NORMALMAP shader feature and updated auto-generation timestamp

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sindharta sindharta changed the title Urp remove normalmap keyword refactor: remove unused _NORMALMAP keyword for URP Dec 29, 2025
@sindharta sindharta changed the title refactor: remove unused _NORMALMAP keyword for URP refactor: remove unused _NORMALMAP and VERSION_LOWER keywords for URP Dec 29, 2025
@sindharta sindharta force-pushed the urp-remove-normalmap-keyword branch from 38d4175 to 0a1f1ca Compare December 29, 2025 07:10
@sindharta sindharta merged commit a68c6a6 into master Dec 29, 2025
24 checks passed
@sindharta sindharta deleted the urp-remove-normalmap-keyword branch December 29, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants