Skip to content

Conversation

@kenyastyle
Copy link
Member

This will be unpopular and other ViennaTools repos will need to be updated as well but I strongly believe we need this renaming for clarity. I have not found any reference in math literature where the schemes from the former IntegrationSchemeEnum are called "integration schemes" because they do no integration. It is part of the reason I was confused about the topic.

It also helps since we already have two time integration methods and possibly more will come.

What do you think?

Copy link
Member

@FilipovicLado FilipovicLado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the naming cleanup. You are right that IntegrationScheme is not the best name. However, DiscretizationScheme is still too generic here, since it doesn't distinguish between time and space discretization.

A clearer name might be SpatialScheme. This keeps the naming precise while avoiding long identifiers like SpatialDiscretizationScheme.

I’d suggest renaming to SpatialScheme instead of DiscretizationScheme.

@tobre1
Copy link
Member

tobre1 commented Dec 19, 2025

I agree this would be a better name.
However, IntegrationScheme is likely already used in some simulation workflows. I suggest renaming it everywhere possible, but keeping IntegrationScheme as an alias and marking it as deprecated in the documentation. We can keep it for a few more releases and then remove it fully.

@FilipovicLado FilipovicLado merged commit 3b7f5a4 into fix_material_interface Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants