Add constructor types #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi there, just bumping this. CI appears to be failing on an unrelated issue. |
Author
|
Hello, any news on if/when this could be merged? It's bitten me again today. |
|
Ran into this issue today as well. Can it please be merged? |
koskimas
force-pushed
the
master
branch
7 times, most recently
from
2cfd284 to
7258cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to instantiate these error classes in TypeScript yielded a warning, since there was no constructor types, it was falling back to the default
Errorconstructor (expecting a singlemessagestring argument).Disclaimer: there might be a better way to implement this without all the duplication, but that would require more TypeScript skills than I currently possess.