Remove proxy feature #501
Merged
Remove proxy feature #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kjy5 <82800265+kjy5@users.noreply.github.com>
Co-authored-by: kjy5 <82800265+kjy5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove deprecated proxy feature and related options
Remove proxy feature
Dec 23, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated proxy feature from Ephys Link, eliminating the ability to run the server as a proxy client. The changes simplify the codebase by removing proxy-related configuration options, initialization logic, event handlers, and associated tests.
- Removed proxy-related CLI arguments (
--use-proxy,--proxy-address) and GUI fields - Simplified server initialization to only support direct server mode (removed proxy client logic)
- Removed proxy-related event handler (
get_pinpoint_id) and associated constants - Updated tests and documentation to reflect the removal of proxy functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/back_end/test_server.py | Removed proxy client tests and unused imports; simplified server fixture initialization |
| src/ephys_link/utils/constants.py | Removed proxy-related error constants (SERVER_NOT_INITIALIZED_ERROR, PROXY_CLIENT_NOT_INITIALIZED_ERROR) |
| src/ephys_link/front_end/gui.py | Removed proxy-related GUI fields (use_proxy checkbox, proxy_address entry) and adjusted grid layout |
| src/ephys_link/front_end/cli.py | Removed proxy-related CLI arguments (--use-proxy, --proxy-address) |
| src/ephys_link/back_end/server.py | Simplified server initialization by removing proxy client logic, AsyncClient imports, and pinpoint_id generation |
| docs/development/socketio_api.md | Removed documentation for the deprecated get_pinpoint_id event |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kjy5
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
get_pinpoint_idSocket.IO event--use-proxy,--proxy-addressNotes
Server now only operates in direct mode. The
use_proxyandproxy_addressfields remain inEphysLinkOptions(external dependency) but are ignored. Net -225 LOC.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.