Skip to content

Conversation

@kjy5
Copy link
Member

@kjy5 kjy5 commented Dec 23, 2025

Copilot AI review requested due to automatic review settings December 23, 2025 22:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses code quality issues by renaming imported symbols that shadow Python built-ins. The main changes involve aliasing ConnectionError and ConnectTimeout from the requests library, and aliasing exit from the sys module to avoid conflicts with built-in names.

  • Renamed requests.ConnectionError to RequestsConnectionError and requests.ConnectTimeout to RequestsConnectTimeout
  • Renamed sys.exit to sys_exit to avoid shadowing the built-in exit()
  • Updated IDE configuration files to reference Python 3.14

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ephys_link/utils/startup.py Aliased requests exceptions to avoid shadowing built-in ConnectionError
tests/utils/test_startup.py Updated test code to use the aliased exception names
src/ephys_link/front_end/gui.py Aliased sys.exit to avoid shadowing built-in exit()
.idea/misc.xml Updated project JDK name to Python 3.14
.idea/ephys-link.iml Updated JDK reference to Python 3.14
.idea/copilot.data.migration.ask2agent.xml Added Copilot migration configuration
.idea/copilot.data.migration.ask.xml Added Copilot migration configuration
Files not reviewed (4)
  • .idea/copilot.data.migration.ask.xml: Language not supported
  • .idea/copilot.data.migration.ask2agent.xml: Language not supported
  • .idea/ephys-link.iml: Language not supported
  • .idea/misc.xml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kjy5 kjy5 merged commit ea72271 into main Dec 23, 2025
12 checks passed
@kjy5 kjy5 deleted the fix-code-quality branch December 23, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to latest communication model to fix ConnectionError shadowing

2 participants